Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-42614

Slice names should be unrestricted

    XMLWordPrintableJSON

Details

    • Icon: Change Request Change Request
    • Resolution: Not Persuasive with Modification
    • Icon: Highest Highest
    • Shorthand (FHIR)
    • 3.0.0-ballot
    • FHIR Infrastructure
    • Normative
    • Language Reference
    • 3.6.7
    • Hide

      We do not agree that slice names should be unrestricted. The FHIR specification itself specifies rules for slice names in eld-16. In addition to the rules specified by FHIR, FHIR Shorthand cannot support slice names with [ or ] characters since those characters are critical to specifying slice names in FSH paths.

      Specification: We will document requirements for slice names in the FSH specification, with reference to FHIR core's constraints. We will also prohibit "[" and "]" in slice names.

      Implementation: We will also attempt to update the ANTLR grammar to allow the use of FSH keywords as slice names. The ANTLR grammar, however, is considered to be informal – so any remaining issues in the grammar should be interpreted as limitations of the implementation, not formal requirements of the specification. We will include comments in the grammar documenting any gap between the specification and the implementation.

      Show
      We do not agree that slice names should be unrestricted. The FHIR specification itself specifies rules for slice names in eld-16 . In addition to the rules specified by FHIR, FHIR Shorthand cannot support slice names with [ or ] characters since those characters are critical to specifying slice names in FSH paths. Specification : We will document requirements for slice names in the FSH specification, with reference to FHIR core's constraints. We will also prohibit " [" and "] " in slice names. Implementation : We will also attempt to update the ANTLR grammar to allow the use of FSH keywords as slice names. The ANTLR grammar, however, is considered to be informal – so any remaining issues in the grammar should be interpreted as limitations of the implementation, not formal requirements of the specification. We will include comments in the grammar documenting any gap between the specification and the implementation.
    • Bas van den Heuvel / Chris Moesel: 12-0-0
    • Correction
    • Non-substantive

    Description

      Slice names should not be restricted. The specification should explicitly state that this is the case. 

      The current ANTLR grammar does not allow this.  When entering slice-names that are keywords within Shorthand, the parser fails with an error.

      This should be fixed. A quick google-search indicates using the `identifier` might allow for this (see antlr - How to prevent identifiers and string keywords from clobbering each other - Stack Overflow).

      Attachments

        Activity

          People

            jafeltra Julia Afeltra
            bvdh Bas van den Heuvel
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: