Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-28242

Test cases are inconsistent with fhir-test-cases

    XMLWordPrintableJSON

Details

    • Icon: Technical Correction Technical Correction
    • Resolution: Persuasive
    • Icon: Medium Medium
    • FHIRPath (FHIR)
    • 1.0
    • Implementable Technology Specifications
    • documentation
    • Hide

      The following changes were made:

      1) Names from the FHIRPath version for all tests were included.

      2) Additional tests defined in the FHIRPath version were added.

      3) Additional tests defined in the fhir-test-cases version were added.

      4) testDivide5 was changed from `1.2 / 1.8 = 0.67` to `1.2 / 1.8 = 0.66666667` per the resolution to this tracker: https://jira.hl7.org/browse/FHIR-19356

      5) testQuantityLiteralWeekToString was changed from `1 week.toString()` resulting in `1 '{week}'` (in the FHIRPath version of the tests) to `1 week.toString()` resulting in `1 'week'`  per the resolution to this tracker: https://jira.hl7.org/browse/FHIR-21606

      6) The following test groups were added: testEncodeDecode, testEscapeUnescape, testTrim, testSplit, testJoin, testSqrt, testAbs, testCeiling, testExp, testLn, testLog, testPower (from the FHIRPath tests)

      7) The following test groups were added: testExists (from the fhir-test-cases tests)

      Show
      The following changes were made: 1) Names from the FHIRPath version for all tests were included. 2) Additional tests defined in the FHIRPath version were added. 3) Additional tests defined in the fhir-test-cases version were added. 4) testDivide5 was changed from `1.2 / 1.8 = 0.67` to `1.2 / 1.8 = 0.66666667` per the resolution to this tracker: https://jira.hl7.org/browse/FHIR-19356 5) testQuantityLiteralWeekToString was changed from `1 week.toString()` resulting in `1 '{week}'` (in the FHIRPath version of the tests) to `1 week.toString()` resulting in `1 'week'`  per the resolution to this tracker: https://jira.hl7.org/browse/FHIR-21606 6) The following test groups were added: testEncodeDecode, testEscapeUnescape, testTrim, testSplit, testJoin, testSqrt, testAbs, testCeiling, testExp, testLn, testLog, testPower (from the FHIRPath tests) 7) The following test groups were added: testExists (from the fhir-test-cases tests)
    • Correction

    Description

      There are 4 different and conflicting versions of the FHIRPath tests:

      https://github.com/HL7/FHIRPath/blob/master/tests/r4/tests-fhir-r4.xml

      https://github.com/FHIR/fhir-test-cases/blob/master/r4/fhirpath/tests-fhir-r4.xml

      https://github.com/HL7/FHIRPath/blob/feature-27757-additional-string-functions/tests/r5/tests-fhir-r5.xml

      https://github.com/FHIR/fhir-test-cases/blob/master/r5/fhirpath/tests-fhir-r5.xml

       

      Discussion on Zulip established consensus that the fhir-test-cases repository should be the source of truth:

      https://github.com/FHIR/fhir-test-cases/blob/master/r5/fhirpath/tests-fhir-r5.xml

      The R5 tests are used since those are the most current, actively maintained branch. However, the R4 tests should be kept consistent as well since they are the ones used in the Normative specification. All test resources used are normative as of R4, so the test resources are identical. The R5 fhir-test-cases should be the source of truth going forward. This ticket is to align all 4 appearances and address any detected conflicts between them.

      Attachments

        Activity

          People

            Unassigned Unassigned
            bryn.rhodes Bryn Rhodes
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: