Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-27499

Improve justification for ELM as an abstract syntax tree

    XMLWordPrintableJSON

Details

    • Icon: Change Request Change Request
    • Resolution: Persuasive
    • Icon: Highest Highest
    • Clinical Quality Language (FHIR)
    • 1.4
    • Clinical Decision Support
    • Introduction
    • 3.2. Logical Perspective
    • Hide

      Add " by making use of existing serialization formats (XML and JSON) to allow direct communication of the semantically verified logic."

      Show
      Add " by making use of existing serialization formats (XML and JSON) to allow direct communication of the semantically verified logic."
    • Ivan Zapreev/Chris Moesel: 19-0-0
    • Clarification
    • Non-substantive

    Description

      Figure 1-B: clearly indicates that first the expression is presented in CQL and then it is parsed into the syntax tree. Therefore the text here seems to be missleading.

      Moreover, even if the representation is as an abstract tree, unless the representation assumes binary object dumping, applications can not avoid parsing these representations. If the ELM is provided to an application in a text format within a file then the application still has to parse the tree to, for instance, create the object model in memory.

      So please either re-work the justification, by clarifying the assumptions, or remove it. From the application stand point, there is no fundamental different in whether to parse the expression or the same expression serialized as a tree. The only difference is if the tree is already present in memory in a kind of object-model form that the application can directly work with in an object oriented faschion.

      Existing Wording:

      As shown here, the ELM representation is defined as an Abstract Syntax Tree, eliminating the need for lexical analysis and parsing steps, and allowing implementations to concentrate on the core representation of the logic.

      Attachments

        Activity

          People

            bryn.rhodes Bryn Rhodes
            ivan_zapreev Ivan Zapreev (Inactive)
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: