Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-36218

Improve documentation in ValueSet.compose.include to clarify AND vs OR

    XMLWordPrintableJSON

Details

    • Icon: Change Request Change Request
    • Resolution: Persuasive with Modification
    • Icon: Medium Medium
    • FHIR Core (FHIR)
    • R5
    • Terminology Infrastructure
    • ValueSet
    • Hide

      Change the existing text in the definition (last sentence)

      If multiple filters are specified, they SHALL all be true. 

      To:

      If multiple filters are specified within the include, they SHALL all be true. 

      Also - the first sentence in the definition has a grammatical error

      Change the existing text:

      Select concepts by specify a matching criterion based on the properties (including relationships) defined by the system, or on filters defined by the system.

      to

      Select concepts by specifying a matching criterion based on the properties (including relationships) defined by the system, or on filters defined by the system.

      Show
      Change the existing text in the definition (last sentence) If multiple filters are specified, they SHALL all be true.  To: If multiple filters are specified within the include , they SHALL all be true.  Also - the first sentence in the definition has a grammatical error Change the existing text: Select concepts by specify a matching criterion based on the properties (including relationships) defined by the system, or on filters defined by the system. to Select concepts by specifying a matching criterion based on the properties (including relationships) defined by the system, or on filters defined by the system.
    • Reuben Daniels/Rob Hausam: 2-0-0
    • Clarification
    • Non-substantive
    • R5

    Description

      The documentation for valueset.compose.filter says the following: "If multiple filters are specified, they SHALL all be true."   However there is actually more flexibility in the rules than this.   If multiple filters are specified in the same include element, then yes they are expected to behave with conjunction (AND) and must all be true.    At the same time, if multiple filters are present by virtue of being in separate include elements, then they are instead expected to behave with disjunction (OR) and so don't all have to be true.

      There is a much clearer explanation for this here:  http://build.fhir.org/valueset.html#compositions

      Please copy a phrase or two from this fuller explanation (or copy a link) into the valueset.compose.filter documentation so as to give a clue to the reader that there is a wider scope to these rules. 

      Attachments

        Activity

          People

            jsnell Jessica Bota
            pgwilliams Peter G. Williams
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: