Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-32848

Differentials include things unchanged from base resource and/or parent profile

    XMLWordPrintableJSON

Details

    • Change Request
    • Status: Published (View Workflow)
    • Medium
    • Resolution: Persuasive with Modification
    • US Core (FHIR)
    • 3.2.0
    • Cross-Group Projects
    • (many)
    • Hide

      Note

      The downsides to having redundancies in the differential is that it implies a change when viewing the differential view.

      Will Work with the publisher to render elements that are unchanged from the base by dimming them with a lighter font.

      If the publishing changes are untimely then will remove them from the source profiles if their absence does not degrade the differential view.  For example, the US Core vitals profile which repeats many FHIR vitals profile elements would be greatly altered and confusing to the reader.

      see attached example careteam profile for how diff would look when implemented.

       

       

      Show
      Note The downsides to having redundancies in the differential is that it implies a change when viewing the differential view. Will Work with the publisher to render elements that are unchanged from the base by dimming them with a lighter font. If the publishing changes are untimely then will remove them from the source profiles if their absence does not degrade the differential view.   For example, the US Core vitals profile which repeats many FHIR vitals profile elements would be greatly altered and confusing to the reader. see attached example careteam profile for how diff would look when implemented.    
    • Eric Haas/Brett Marquard: 26-0-1
    • Enhancement
    • Non-substantive

    Description

      The differentials in US Core frequently indicate things that have changed that in truth have  not changed from the parent. This doesn't affect the functionality of the profile, but does mislead the degree to which US Core is changing things compared to the base. 

      An example is shown in the file overspecified-condition-profile.png. Compare the black text on the left with greyed-out text on the right. The greyed-out text are things inherited from the parent that have not changed. There are 10 things in this one differential that are inaccurately displayed on the left as being altered in the profile.

      I have enclosed the file fshing-trip.html that has a complete analysis of where this occurs. You should be looking for situations where there is text on the left that is not repeated on the right, as shown in the overspecified-profile.png file. 

      PS – I have also included for your reference a complete translation of US Core 3.2 into FSH. I am  doing the conversion of US Core to FSH as a brief demo at June 2021 DevDays. In doing so I turned up this and several other issues in the build version you might want to address.  

      Attachments

        Activity

          People

            ehaas Eric Haas
            Mark_Kramer Mark Kramer
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: