Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-28115

ref-1 constraint contains a debug function

    XMLWordPrintableJSON

Details

    • Icon: Change Request Change Request
    • Resolution: Not Persuasive
    • Icon: Medium Medium
    • FHIR Core (FHIR)
    • R4
    • FHIR Infrastructure
    • References
    • Hide

      https://www.hl7.org/fhir/fhirpath.html documents behavior for ".trace()" that provides value here: creating better user-facing error messages.

      We'll close this issue; but if the perceived value of these error messages is insufficient, we can raise another issue to discuss the trade-off.

      Show
      https://www.hl7.org/fhir/fhirpath.html  documents behavior for ".trace()" that provides value here: creating better user-facing error messages. We'll close this issue; but if the perceived value of these error messages is insufficient, we can raise another issue to discuss the trade-off.
    • Grahame Grieve / Rick Geimer: 12-0-0

    Description

      The `ref-1` constraint looks like this:

      ```
      reference.startsWith('#').not() or (reference.substring(1).trace('url') in %rootResource.contained.id.trace('ids'))
      ```

      This constraint contains the `trace()` function, which has no real use in production systems and will likely trigger log or console output in the FhirPath evaluator. Since ref-1 is a very common constraint, this might affect validation performance, for no added benefit.

      I propose removing the call to `trace()` in this constraint.

      Attachments

        Activity

          People

            Unassigned Unassigned
            ewout Ewout Kramer
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: