Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-27498

A number of Figure improvements

    XMLWordPrintableJSON

Details

    • Icon: Change Request Change Request
    • Resolution: Persuasive with Modification
    • Icon: Highest Highest
    • Clinical Quality Language (FHIR)
    • 1.4
    • Clinical Decision Support
    • Introduction
    • 3.2. Logical Perspective
    • Hide

      Add the following explanatory paragraph after the diagram:

      The process begins with lexical analysis, turning the raw CQL text into a stream of tokens according to the lexical rules of the language. In this case, the stream of tokens `x`, `+`, `y`, `*`, `z`. The next step is parsing, which operates on the stream of tokens to produce an Abstract Syntax Tree or AST, that is a representation of the statement according to the grammar rules of the language. The next step, depicted by the next tree, is semantic analysis, or the process of verifying the "meaning" of the statement. In this case, semantic analysis resolves the `+` to an addition operation with integer-valued inputs, and the `x`, `y`, and `z` to symbol references (i.e. references to expression definitions).

      Show
      Add the following explanatory paragraph after the diagram: The process begins with lexical analysis, turning the raw CQL text into a stream of tokens according to the lexical rules of the language. In this case, the stream of tokens `x`, `+`, `y`, `*`, `z`. The next step is parsing, which operates on the stream of tokens to produce an Abstract Syntax Tree or AST, that is a representation of the statement according to the grammar rules of the language. The next step, depicted by the next tree, is semantic analysis, or the process of verifying the "meaning" of the statement. In this case, semantic analysis resolves the `+` to an addition operation with integer-valued inputs, and the `x`, `y`, and `z` to symbol references (i.e. references to expression definitions).
    • Kensaku Kawamoto/Ricardo Quintano: 18-0-0
    • Clarification
    • Non-substantive

    Description

      Figure 1-B: can be improved in several ways:

      1. Make horizontal lines dividing different layers between each other.
      2. "Physical level" is not the best term here as physical means hardware and binary code is an encoding and is not physical in nature. I would suggest using "Machine level" instead.
      3. Distinguish between the data and the transformations/analysis: Make the data into blocks and the analysis actions put onto arrows connecting the data blocks. For instance The CQL expression is connected to the ELM model via an arrow labelled with "Parsing" (Note that lexical analysis or tokenization can be considered as part of parsing).
      4. Why do you have two types of trees on the Figure?
      5. Why the "z" node is labeled with "symbol(z)" and nodes "x" and "y" are not?
      6. What is the meaning of "symbol(z)"?

      Attachments

        1. image-2020-08-03-14-15-50-894.png
          image-2020-08-03-14-15-50-894.png
          36 kB

        Activity

          People

            bryn.rhodes Bryn Rhodes
            ivan_zapreev Ivan Zapreev (Inactive)
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: