Uploaded image for project: 'FHIR Specification Feedback'
  1. FHIR Specification Feedback
  2. FHIR-25837

Make explicit in the spec that when using websockets the unsubscription will simply remove the websocket endpoint.

    XMLWordPrintableJSON

    Details

    • Type: Change Request
    • Status: Applied (View Workflow)
    • Priority: Highest
    • Resolution: Persuasive with Modification
    • Specification:
      FHIRCast (FHIR)
    • Raised in Version:
      0.1
    • Work Group:
      Imaging Integration
    • Related Page(s):
      (NA)
    • Related Section(s):
      Subscribing and Unsubscribing
    • Grouping:
    • Resolution Description:
      Hide

      Suggestion from Bas:

       

      Make explicit in the spec that when using websockets the unsubscription will simply remove the websocket endpoint.

      What will happen with the websocket disconnected? I assume that it will remain and can reconnect. Another approach would be to re-subscribe and treat the disconnect as an unsubscribe. This approach has the elegance that there will be no dangling websockets. What do you think?

       

      Pursuasive:

      Add clarification that when unsubscribing a websocket subscription, the websocket will be destroyed. A new subscription will receive a new websocket connection, the old one will not be used.

      Show
      Suggestion from Bas:   Make explicit in the spec that when using websockets the unsubscription will simply remove the websocket endpoint. What will happen with the websocket disconnected? I assume that it will remain and can reconnect. Another approach would be to re-subscribe and treat the disconnect as an unsubscribe. This approach has the elegance that there will be no dangling websockets. What do you think?   Pursuasive: Add clarification that when unsubscribing a websocket subscription, the websocket will be destroyed. A new subscription will receive a new websocket connection, the old one will not be used.
    • Resolution Vote:
      Isaac Vetter / Eric Martin : 5-0-0
    • Change Category:
      Clarification
    • Change Impact:
      Compatible, substantive

      Description

      Make explicit in the spec that when using websockets the unsubscription will simply remove the websocket endpoint.

      What will happen with the websocket disconnected? I assume that it will remain and can reconnect. Another approach would be to re-subscribe and treat the disconnect as an unsubscribe. This approach has the elegance that there will be no dangling websockets. What do you think?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              niklas_svenzen Niklas Svenzen
              Reporter:
              bvdh Bas van den Heuvel
              Request in-person:
              Bas van den Heuvel
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Vote Date: